Skip to content

Apply 2.0.3 to dev#243

Merged
sainsachiko merged 8 commits into
devfrom
main
May 15, 2026
Merged

Apply 2.0.3 to dev#243
sainsachiko merged 8 commits into
devfrom
main

Conversation

@sainsachiko

Copy link
Copy Markdown
Contributor

Apply 2.0.3 to dev

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

sainsachiko and others added 8 commits May 15, 2026 13:20
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Agent-Logs-Url: https://github.com/sanger-tol/readmapping/sessions/a61689a5-a2a7-402a-bd52-58075aec1701

Co-authored-by: sainsachiko <134130358+sainsachiko@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@sanger-tolsoft

Copy link
Copy Markdown
Contributor

Warning

Newer version of the nf-core template is available.

Your pipeline is using an old version of the nf-core template: 3.5.2.
Please update your pipeline to the latest version.

For more documentation on how to update your pipeline, please see the nf-core documentation and Synchronisation documentation.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR applies the v2.0.3 release metadata and updates PacBio barcode handling so empty barcode values are accepted and covered by refreshed snapshots.

Changes:

  • Bumped pipeline metadata and release references from 2.0.2 to 2.0.3.
  • Updated PacBio adapter YAML handling to avoid barcode substitution when barcode is empty.
  • Updated samplesheet documentation, example data, and nf-test snapshots.

Reviewed changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
.nf-core.yml Updates template version to 2.0.3.
CHANGELOG.md Adds v2.0.3 release notes.
CITATION.cff Updates citation release metadata.
assets/samplesheet.csv Adds an empty-barcode PacBio example case.
docs/usage.md Documents required and optional samplesheet columns.
nextflow.config Bumps manifest version.
nextflow_schema.json Clarifies input CSV may have at least four columns.
ro-crate-metadata.json Updates RO-Crate context and release metadata.
subworkflows/local/align_long.nf Branches PacBio YAML handling by barcode presence.
tests/default.nf.test.snap Refreshes default snapshot outputs for v2.0.3 and empty barcode behavior.
tests/short_aligner_minimap2.nf.test.snap Refreshes workflow version snapshot.
tests/uli.nf.test.snap Refreshes workflow version snapshot.
tests/uli_no_lima.nf.test.snap Refreshes workflow version snapshot.
tests/untrim.nf.test.snap Refreshes workflow version snapshot.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

],
{

@github-actions

github-actions Bot commented May 15, 2026

Copy link
Copy Markdown

nf-core pipelines lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 059f168

+| ✅ 212 tests passed       |+
#| ❔  34 tests were ignored |#
!| ❗   9 tests had warnings |!
Details

❗ Test warnings:

❔ Tests ignored:

  • files_exist - File is ignored: CODE_OF_CONDUCT.md
  • files_exist - File is ignored: assets/multiqc_config.yml
  • files_exist - File is ignored: assets/nf-core-readmapping_logo_light.png
  • files_exist - File is ignored: assets/methods_description_template.yml
  • files_exist - File is ignored: conf/igenomes.config
  • files_exist - File is ignored: docs/images/nf-core-readmapping_logo_dark.png
  • files_exist - File is ignored: docs/images/nf-core-readmapping_logo_light.png
  • files_exist - File is ignored: .github/ISSUE_TEMPLATE/config.yml
  • files_exist - File is ignored: .github/workflows/awstest.yml
  • files_exist - File is ignored: .github/workflows/awsfulltest.yml
  • files_exist - File is ignored: tower.yml
  • nextflow_config - Config variable ignored: manifest.name
  • nextflow_config - Config variable ignored: manifest.homePage
  • nextflow_config - Config default ignored: params.pacbio_adapter_fasta
  • nextflow_config - Config default ignored: params.pacbio_adapter_yaml
  • files_unchanged - File ignored due to lint config: .gitattributes
  • files_unchanged - File does not exist: CODE_OF_CONDUCT.md
  • files_unchanged - File ignored due to lint config: LICENSE or LICENSE.md or LICENCE or LICENCE.md
  • files_unchanged - File ignored due to lint config: .github/CONTRIBUTING.md
  • files_unchanged - File ignored due to lint config: .github/ISSUE_TEMPLATE/bug_report.yml
  • files_unchanged - File does not exist: .github/ISSUE_TEMPLATE/config.yml
  • files_unchanged - File ignored due to lint config: .github/PULL_REQUEST_TEMPLATE.md
  • files_unchanged - File ignored due to lint config: .github/workflows/branch.yml
  • files_unchanged - File ignored due to lint config: .github/workflows/linting_comment.yml
  • files_unchanged - File ignored due to lint config: .github/workflows/linting.yml
  • files_unchanged - File ignored due to lint config: assets/email_template.html
  • files_unchanged - File ignored due to lint config: assets/sendmail_template.txt
  • files_unchanged - File does not exist: assets/nf-core-readmapping_logo_light.png
  • files_unchanged - File does not exist: docs/images/nf-core-readmapping_logo_light.png
  • files_unchanged - File does not exist: docs/images/nf-core-readmapping_logo_dark.png
  • files_unchanged - File ignored due to lint config: docs/README.md
  • files_unchanged - File ignored due to lint config: .gitignore or .prettierignore
  • actions_awstest - 'awstest.yml' workflow not found: /home/runner/work/readmapping/readmapping/.github/workflows/awstest.yml
  • multiqc_config - multiqc_config

✅ Tests passed:

Run details

  • nf-core/tools version 3.5.2
  • Run at 2026-05-15 17:22:54

@sainsachiko sainsachiko merged commit 58234e7 into dev May 15, 2026
53 of 55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants